netdev - Re: [PATCH net-next-2.6] net: timestamp cloned packet in dev_queue_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTin6pzkUAcmH12ywTsRAABEKch9=iHziZ0oURZYd@mail.gmail.com>
Date:	Tue, 21 Dec 2010 15:56:17 +0800
From:	Changli Gao <xiaosuo@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Patrick McHardy <kaber@...sh.net>,
	Jarek Poplawski <jarkao2@...il.com>
Subject: Re: [PATCH net-next-2.6] net: timestamp cloned packet in dev_queue_xmit_nit

On Tue, Dec 21, 2010 at 3:22 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> Le vendredi 17 décembre 2010 à 10:26 +0100, Eric Dumazet a écrit :
>
>>
>> I think we can add this after latest Changli patch :
>>
>> He does one skb_clone() before calling the sniffers.
>> We could set timestamp on this clone, instead of original skb.
>>
>> Problem solved.
>>
>
> [PATCH net-next-2.6] net: timestamp cloned packet in dev_queue_xmit_nit
>
> Now we do one clone of skb if at least one sniffer might take packet,
> we also can do the skb timestamping on the clone and let original packet
> unchanged.
>
> This is a generalization of commit 8caf153974f2 (net: sch_netem: Fix an
> inconsistency in ingress netem timestamps.)
>
> This way, we can have a good idea when packets are delivered to our
> stack (tcpdump -i ifb0), while a tcpdump on original device gives
> timestamps right before ingressing.
>
> This also speedup our stack, avoiding taking timestamps if not needed.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Changli Gao <xiaosuo@...il.com>
> Cc: Patrick McHardy <kaber@...sh.net>
> Cc: Jarek Poplawski <jarkao2@...il.com>

Acked-by: Changli Gao <xiaosuo@...il.com>


-- 
Regards,
Changli Gao(xiaosuo@...il.com)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html