| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <AANLkTincx8rSM+72czJ+tTrG=D=aOJLBb9nd9Jt_RsD2@mail.gmail.com> Date: Sat, 25 Dec 2010 22:40:11 +0100 From: richard -rw- weinberger <richard.weinberger@...il.com> To: Jesper Juhl <jj@...osbits.net> Cc: ceph-devel@...r.kernel.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, Sage Weil <sage@...dream.net>, "David S. Miller" <davem@...emloft.net> Subject: Re: [PATCH] Ceph: Fix a use-after-free bug in ceph_destroy_client(). On Sat, Dec 25, 2010 at 10:24 PM, Jesper Juhl <jj@...osbits.net> wrote: > On Sat, 25 Dec 2010, richard -rw- weinberger wrote: > >> On Sat, Dec 25, 2010 at 7:17 PM, Jesper Juhl <jj@...osbits.net> wrote: >> > Hello, >> > >> > In net/ceph/ceph_common.c::ceph_destroy_client() the pointer 'client' is >> > freed by kfree() and subsequently used in a call to dout() - use after >> > free bug. >> >> Not really. %p reads only the address of "client". >> kfree() does not alter this address. >> > > Ok, I see your point and you are correct. But still, the patch does not > change behaviour and it makes it absolutely clear that there's no > use-after-free bug, so it might still have merit... or? Your patch does not fix a bug. I would say it's a style fix. > -- > Jesper Juhl <jj@...osbits.net> http://www.chaosbits.net/ > Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html > Plain text mails only, please. > > -- Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists