lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1293700797.2400.13.camel@Joe-Laptop> Date: Thu, 30 Dec 2010 01:19:57 -0800 From: Joe Perches <joe@...ches.com> To: Michał Mirosław <mirq-linux@...e.qmqm.pl> Cc: Hans Ulli Kroll <ulli.kroll@...glemail.com>, gemini-board-dev@...ts.berlios.de, netdev@...r.kernel.org, Christoph Biedl <linux-kernel.bfrz@...chmal.in-ulm.de> Subject: Re: [PATCH v4] Gemini: Gigabit ethernet driver On Thu, 2010-12-30 at 09:39 +0100, Michał Mirosław wrote: > Driver for SL351x (Gemini) SoC ethernet peripheral. Based in part > on work by Paulius Zaleckas and GPLd code from Raidsonic and other > NAS vendors. > Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl> > diff --git a/drivers/net/sl351x.c b/drivers/net/sl351x.c Output trivia: > +static void gmac_tx_interrupt(struct net_device *dev, unsigned txq_num) [] > + netif_info(gmac, tx_done, dev, "txirq%u: %u,%u,%u\n", > + txq_num, txq->cptr, GET_RPTR(ptr_reg), GET_WPTR(ptr_reg)); pointers as decimal? There seems to be a lot of output using %u where I expected %08x. > +static int gmac_start_xmit(struct sk_buff *skb, struct net_device *dev) [] > + netif_info(gmac, tx_queued, dev, "txq%u: %u,%u,%u ? %p (%u @ %p) /%u\n", > + txq_num, txq->cptr, GET_RPTR(ptr_reg), GET_WPTR(ptr_reg), > + skb, skb->len, skb->data, skb_shinfo(skb)->gso_size); [] > + netif_info(gmac, tx_queued, dev, "txq%u: %u,%u,%u + %p\n", > + txq_num, txq->cptr, GET_RPTR(ptr_reg), w, skb); [] > +static unsigned gmac_rx(struct net_device *dev, unsigned budget) [] > + netif_info(gmac, rx_status, dev, "rxq: %u,%u\n", > + GET_RPTR(ptr_reg), GET_WPTR(ptr_reg)); etc... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists