netdev - Re: [PATCH v4] Gemini: Gigabit ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101230094821.GA24281@rere.qmqm.pl>
Date:	Thu, 30 Dec 2010 10:48:21 +0100
From:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:	Joe Perches <joe@...ches.com>
Cc:	Hans Ulli Kroll <ulli.kroll@...glemail.com>,
	gemini-board-dev@...ts.berlios.de, netdev@...r.kernel.org,
	Christoph Biedl <linux-kernel.bfrz@...chmal.in-ulm.de>
Subject: Re: [PATCH v4] Gemini: Gigabit ethernet driver

On Thu, Dec 30, 2010 at 01:19:57AM -0800, Joe Perches wrote:
> On Thu, 2010-12-30 at 09:39 +0100, Michał Mirosław wrote:
> > Driver for SL351x (Gemini) SoC ethernet peripheral. Based in part
> > on work by Paulius Zaleckas and GPLd code from Raidsonic and other
> > NAS vendors.
> > Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> > diff --git a/drivers/net/sl351x.c b/drivers/net/sl351x.c
> 
> Output trivia:
> 
> > +static void gmac_tx_interrupt(struct net_device *dev, unsigned txq_num)
> []
> > +	netif_info(gmac, tx_done, dev, "txirq%u: %u,%u,%u\n",
> > +		txq_num, txq->cptr, GET_RPTR(ptr_reg), GET_WPTR(ptr_reg));
> 
> pointers as decimal?
> There seems to be a lot of output using %u where I expected %08x.

These are indexes into TX/RX/RXbuf(FreeQ) rings. It's usually easier to read
them in decimal by humans. ;) I kept the notation of 'PTR' from the original
hardware register names.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html