netdev - Re: [PATCH v4] Gemini: Gigabit ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1012301236400.18031@localhost>
Date:	Thu, 30 Dec 2010 12:48:47 +0100 (CET)
From:	Hans Ulli Kroll <ulli.kroll@...glemail.com>
To:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
cc:	Hans Ulli Kroll <ulli.kroll@...glemail.com>,
	gemini-board-dev@...ts.berlios.de, netdev@...r.kernel.org,
	Christoph Biedl <linux-kernel.bfrz@...chmal.in-ulm.de>
Subject: Re: [PATCH v4] Gemini: Gigabit ethernet driver

On Thu, 30 Dec 2010, Michał Mirosław wrote:

> Driver for SL351x (Gemini) SoC ethernet peripheral. Based in part
> on work by Paulius Zaleckas and GPLd code from Raidsonic and other
> NAS vendors.
> 
> Tested on Raidsonic IcyBox 4220-B (dual SATA NAS).
> 
> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> ---
> 

Hi Michał,

I've make a quick compile and run test on my IB4220
Looks good.

But we must include the file gmac.h from 
arch/arm/mach-gemini/include/mach.
We break the build, if we don't do this.

Other issue is the __raw_writel and __raw_readl functions, we can switch 
to readl and writel. This is due some mistake of the original developer 
(Stormlinksemi) who doesn't understand endianes on ARM

I've tested this driver on my IB4220 only in 100MBit/s mode. PHY is broken.

I have another IB4220 at my home with working PHY

Ulli