netdev - Re: [PATCH] atl1: fix oops when changing tx/rx ring params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101231.120831.232749764.davem@davemloft.net>
Date:	Fri, 31 Dec 2010 12:08:31 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jcliburn@...il.com
Cc:	jussuf@...ux.ee, kronos.it@...il.com, chris.snook@...il.com,
	netdev@...r.kernel.org, Xiong.Huang@...eros.com, stable@...nel.org
Subject: Re: [PATCH] atl1: fix oops when changing tx/rx ring params

From: "J. K. Cliburn" <jcliburn@...il.com>
Date: Mon, 27 Dec 2010 09:54:02 -0600

> @@ -3544,11 +3546,20 @@ static int atl1_set_ringparam(struct net_device *netdev,
>  		adapter->rrd_ring = rrd_old;
>  		adapter->tpd_ring = tpd_old;
>  		adapter->ring_header = rhdr_old;
> +		/*
> + 		 * Save SMB and CMB, since atl1_free_ring_resources
> + 		 * will clear them as a result of commit
> + 		 * 3f5a2a713aad28480d86b0add00c68484b54febc
> + 		 */

Please do not reference commit IDs in code comments.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html