netdev - Re: [PATCH v2] tg3: fix return value check in tg3_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101231.123116.229747013.davem@davemloft.net>
Date:	Fri, 31 Dec 2010 12:31:16 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dsterba@...e.cz
Cc:	mcarlson@...adcom.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, mchan@...adcom.com
Subject: Re: [PATCH v2] tg3: fix return value check in tg3_read_vpd()

From: David Sterba <dsterba@...e.cz>
Date: Wed, 29 Dec 2010 14:40:31 +0100

> Besides -ETIMEDOUT and -EINTR, pci_read_vpd may return other error
> values like -ENODEV or -EINVAL which are ignored due to the buggy
> check, but the data are not read from VPD anyway and this is checked
> subsequently with at most 3 needless loop iterations. This does not
> show up as a runtime bug.
> 
> CC: Matt Carlson <mcarlson@...adcom.com>
> CC: Michael Chan <mchan@...adcom.com>
> Signed-off-by: David Sterba <dsterba@...e.cz>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html