netdev - Re: [PATCH net-2.6] starfire: Fix dma_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101231.123443.35039907.davem@davemloft.net>
Date:	Fri, 31 Dec 2010 12:34:43 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ben@...adent.org.uk
Cc:	ionut@...ula.org, akinobu.mita@...il.com,
	fujita.tomonori@....ntt.co.jp, netdev@...r.kernel.org
Subject: Re: [PATCH net-2.6] starfire: Fix dma_addr_t size test for MIPS

From: Ben Hutchings <ben@...adent.org.uk>
Date: Wed, 29 Dec 2010 14:26:17 +0000

> Commit 56543af "starfire: use BUILD_BUG_ON for netdrv_addr_t" revealed
> that the preprocessor condition used to find the size of dma_addr_t
> yielded the wrong result for some architectures and configurations.
> This was kluged for 64-bit PowerPC in commit 3e502e6 by adding yet
> another case to the condition.  However, 64-bit MIPS configurations
> are not detected reliably either.
> 
> This should be fixed by using CONFIG_ARCH_DMA_ADDR_T_64BIT, but that
> isn't yet defined everywhere it should be.
> 
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>

Applied to net-2.6, thanks.

> The MIPS conditions are changed to match those Tomonori specified for
> CONFIG_ARCH_DMA_ADDR_T_64BIT.
> 
> Please change the condition to defined(CONFIG_ARCH_DMA_ADDR_T_64BIT) in
> net-next-2.6.  I leave it up to you to decide when to make that change.
> (Simply applying a patch to net-next-2.6 now will result in a later
> merge conflict and breakage for those two architectures.)

The thing to do here is to make this change after the next merge
window takes in Fujita's patch definiting ARCH_DMA_ADDR_T_64BIT from
the -mm set.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html