netdev - Re: [net-next-2.6 02/08] r8169: identify different registers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1294023131.3167.138.camel@localhost>
Date:	Mon, 03 Jan 2011 02:52:11 +0000
From:	Ben Hutchings <benh@...ian.org>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Hayes Wang <hayeswang@...ltek.com>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [net-next-2.6 02/08] r8169: identify different registers.

On Mon, 2011-01-03 at 00:36 +0100, Francois Romieu wrote:
> Documentation (sort of).
> 
> The location are the same, the values are the same but it is
> just accidental. Note that the 810x could cope with a smaller
> value as it does not support jumbo frames.
> 
> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> Cc: Hayes <hayeswang@...ltek.com>
> ---
>  drivers/net/r8169.c |   22 ++++++++++++++--------
>  1 files changed, 14 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
> index 3124462..8aa92ad 100644
> --- a/drivers/net/r8169.c
> +++ b/drivers/net/r8169.c
[...]
> @@ -3036,7 +3042,7 @@ static void rtl_hw_start_8168bef(void __iomem *ioaddr, struct pci_dev *pdev)
>  {
>  	rtl_hw_start_8168bb(ioaddr, pdev);
>  
> -	RTL_W8(EarlyTxThres, EarlyTxThld);
> +	RTL_W8(MaxTxPacketSize, 0x3f);
[...]

Shouldn't the value here be written as TxPacketMax?

Ben.

-- 
Ben Hutchings, Debian Developer and kernel team member


Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)