netdev - Re: [net-next-2.6 02/08] r8169: identify different registers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110102.185806.226760329.davem@davemloft.net>
Date:	Sun, 02 Jan 2011 18:58:06 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	benh@...ian.org
Cc:	romieu@...zoreil.com, netdev@...r.kernel.org,
	hayeswang@...ltek.com, dwmw2@...radead.org
Subject: Re: [net-next-2.6 02/08] r8169: identify different registers.

From: Ben Hutchings <benh@...ian.org>
Date: Mon, 03 Jan 2011 02:52:11 +0000

> On Mon, 2011-01-03 at 00:36 +0100, Francois Romieu wrote:
>> Documentation (sort of).
>> 
>> The location are the same, the values are the same but it is
>> just accidental. Note that the 810x could cope with a smaller
>> value as it does not support jumbo frames.
>> 
>> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
>> Cc: Hayes <hayeswang@...ltek.com>
>> ---
>>  drivers/net/r8169.c |   22 ++++++++++++++--------
>>  1 files changed, 14 insertions(+), 8 deletions(-)
>> 
>> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
>> index 3124462..8aa92ad 100644
>> --- a/drivers/net/r8169.c
>> +++ b/drivers/net/r8169.c
> [...]
>> @@ -3036,7 +3042,7 @@ static void rtl_hw_start_8168bef(void __iomem *ioaddr, struct pci_dev *pdev)
>>  {
>>  	rtl_hw_start_8168bb(ioaddr, pdev);
>>  
>> -	RTL_W8(EarlyTxThres, EarlyTxThld);
>> +	RTL_W8(MaxTxPacketSize, 0x3f);
> [...]
> 
> Shouldn't the value here be written as TxPacketMax?

Yep, looks that way to me too.

Otherwise why add the new TxPacketMax definition :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html