netdev - Re: [PATCH net-next-2.6] bonding: remove meaningless /sys/module/bonding/parameters entries.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110103.113212.260088613.davem@davemloft.net>
Date:	Mon, 03 Jan 2011 11:32:12 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	nicolas.2p.debian@...e.fr
Cc:	bonding-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	fubar@...ibm.com
Subject: Re: [PATCH net-next-2.6] bonding: remove meaningless
 /sys/module/bonding/parameters entries.

From: Nicolas de Pesloüan <nicolas.2p.debian@...e.fr>
Date: Sun,  2 Jan 2011 15:35:15 +0100

> Only two bonding parameters are exposed in /sys/module/bonding:
> 
> num_grat_arp
> num_unsol_na
> 
> Those values are not module global, but per device.
> 
> The per device values are available in /sys/class/net/<device>/bonding.
> 
> The values exposed in /sys/module/bonding are those given at module load time
> and only used as default values when creating a device. They are read-only and
> cannot change in any way.
> 
> As such, they are mostly meaningless.

First, you forgot to provide a proper "Signed-off-by: " line in your
patch submission, please read Documentation/SubmittingPatches

Secondly, you can't remove these, people might be using them.  It
could be useful, for example, to debug problems with passing module
parameters in.  This is the one way to find out what actually got
passed to the module when it loaded.

Therefore I'm not applying this patch, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html