netdev - [PATCH net-next-2.6] bonding: remove meaningless /sys/module/bonding/parameters entries.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun,  2 Jan 2011 15:35:15 +0100
From:	Nicolas de Pesloüan 
	<nicolas.2p.debian@...e.fr>
To:	bonding-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	fubar@...ibm.com, davem@...emloft.net
Cc:	nicolas.2p.debian@...e.fr
Subject: [PATCH net-next-2.6] bonding: remove meaningless /sys/module/bonding/parameters entries.

Only two bonding parameters are exposed in /sys/module/bonding:

num_grat_arp
num_unsol_na

Those values are not module global, but per device.

The per device values are available in /sys/class/net/<device>/bonding.

The values exposed in /sys/module/bonding are those given at module load time
and only used as default values when creating a device. They are read-only and
cannot change in any way.

As such, they are mostly meaningless.
---
 drivers/net/bonding/bond_main.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index b1025b8..b7fd966 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -116,9 +116,9 @@ module_param(max_bonds, int, 0);
 MODULE_PARM_DESC(max_bonds, "Max number of bonded devices");
 module_param(tx_queues, int, 0);
 MODULE_PARM_DESC(tx_queues, "Max number of transmit queues (default = 16)");
-module_param(num_grat_arp, int, 0644);
+module_param(num_grat_arp, int, 0);
 MODULE_PARM_DESC(num_grat_arp, "Number of gratuitous ARP packets to send on failover event");
-module_param(num_unsol_na, int, 0644);
+module_param(num_unsol_na, int, 0);
 MODULE_PARM_DESC(num_unsol_na, "Number of unsolicited IPv6 Neighbor Advertisements packets to send on failover event");
 module_param(miimon, int, 0);
 MODULE_PARM_DESC(miimon, "Link check interval in milliseconds");
-- 
1.7.2.3

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html