netdev - Re: [PATCH] net_sched: pfifo_head

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110105.133940.179942285.davem@davemloft.net>
Date:	Wed, 05 Jan 2011 13:39:40 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	hagen@...u.net
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org, fw@...len.de,
	kaber@...sh.net, shemminger@...tta.com, jarkao2@...il.com
Subject: Re: [PATCH] net_sched: pfifo_head_drop problem

From: Hagen Paul Pfeifer <hagen@...u.net>
Date: Wed, 5 Jan 2011 21:52:17 +0100

> * Eric Dumazet | 2011-01-05 21:35:02 [+0100]:
> 
>>My mid term suggestion would be to change things so that
>>sch->bstats.bytes and sch->bstats.packets are incremented in dequeue()
>>only, not at enqueue() time. We also could add drop_bytes/drop_packets
>>and provide estimations of drop rates.
>>
>>It would be more sensible anyway for very low speeds, and big bursts.
>>Right now, if we drop packets, they still are accounted in byte/packets
>>abolute counters and rate estimators.
>>
>>Before this mid term change, this patch makes pfifo_head_drop behavior
>>similar to other qdiscs in case of drops :
>>Dont decrement sch->bstats.bytes and sch->bstats.packets
> 
> Thanks Stephen and Erik for spotting this bug!
> 
>>Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> 
> Acked-by: Hagen Paul Pfeifer <hagen@...u.net>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html