netdev - Re: [PATCH net-next-2.6 v2 2/2] can: add driver for Softing card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110106062635.GA375@e-circ.dyndns.org>
Date:	Thu, 6 Jan 2011 07:26:36 +0100
From:	Kurt Van Dijck <kurt.van.dijck@....be>
To:	Wolfgang Grandegger <wg@...ndegger.com>
Cc:	netdev@...r.kernel.org, socketcan-core@...ts.berlios.de
Subject: Re: [PATCH net-next-2.6 v2 2/2] can: add driver for Softing card

On Wed, Jan 05, 2011 at 10:02:16PM +0100, Wolfgang Grandegger wrote:
> > +
> > +config CAN_SOFTING_CS
> > +	tristate "Softing CAN pcmcia cards"
> > +	depends on PCMCIA
> 
> Does it not also depend on CAN_SOFTING?
> 
IMO not in a way that requires a depends here.
As a user, when I use the card, I definitely will want CAN_SOFTING,
since CAN_SOFTING_CS will only create a platform device as abstraction
of the DPRAM interface.
CAN_SOFTING will then create the CAN network devices on top of that,
but there is no object dependancy.
That's different than with SJA1000.

Kurt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html