netdev - typo in ping.c?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <00c001cbad52$e62ea050$b28be0f0$@aquezada.com>
Date:	Wed, 5 Jan 2011 22:36:27 -0500
From:	"Julian C. Dunn" <jdunn@...ezada.com>
To:	<netdev@...r.kernel.org>
Subject: typo in ping.c?

I sent this about a month ago to Yoshifuji Hideaki but didn't hear anything.
Perhaps it could use a wider distribution.

- Julian

-----Original Message-----
From: Julian C. Dunn [mailto:jdunn@...ezada.com] 
Sent: Sunday, December 12, 2010 8:49 PM
To: 'YOSHIFUJI Hideaki'
Subject: typo in ping.c?

Hi,

I'm not an expert in C code or in iputils but I think I found a
typographical error in this commit:

http://www.linux-ipv6.org/gitweb/gitweb.cgi?p=gitroot/iputils.git;a=commitdi
ff;h=d5e3dcb81ff3828fa40eb4e8c562ca7015d7ac6a

The previous version printed the icmp_seq inline within ping_common.c, but
in your diff you are now invoking a function void pr_echo_reply().
Unfortunately, it looks like "icmp_seq" is spelled wrong: you have it
spelled as "icmp_req".

I discovered this when trying to use a tool that depended on the spelling of
"icmp_seq" and it failed.

- Julian

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html