netdev - Re: [net-next 12/12] ixgbe: update ntuple filter configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=yczts7TSHwGcbZ-gyyhOi+ya0byC6R4f80c1A@mail.gmail.com>
Date:	Thu, 6 Jan 2011 20:12:00 -0800
From:	Alexander Duyck <alexander.duyck@...il.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	jeffrey.t.kirsher@...el.com, davem@...emloft.net,
	Alexander Duyck <alexander.h.duyck@...el.com>,
	netdev@...r.kernel.org, gosp@...hat.com, bphilips@...ell.com
Subject: Re: [net-next 12/12] ixgbe: update ntuple filter configuration

On Thu, Jan 6, 2011 at 5:02 PM, Ben Hutchings <bhutchings@...arflare.com> wrote:
> On Thu, 2011-01-06 at 16:29 -0800, jeffrey.t.kirsher@...el.com wrote:
>> From: Alexander Duyck <alexander.h.duyck@...el.com>
>>
>> This change fixes several issues found in ntuple filtering while I was
>> doing the ATR refactor.
>>
>> Specifically I updated the masks to work correctly with the latest version
>> of ethtool,
> [...]
>
> Did the previous code not correctly handle a zero value with a non-zero
> mask for some fields?  If so, I can revert that change to ethtool.
>
> Ben.

Actually I think the ethtool mention doesn't really apply to the
in-kernel driver. I think I just carried that over from the check-in
for our out of tree driver which hadn't been updated when you added
the code to cleanup the rx ntuple filters.  Also for the driver I'm
not too worried about what the status of it was before since there are
blatant errors in bit/byte ordering and mask bit values in the code
that from what I can tell would have significantly diminished the
usability of the filters.

Thanks,

Alex
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html