lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Jan 2011 10:41:18 -0500 From: Jesse Gross <jesse@...ira.com> To: jeffrey.t.kirsher@...el.com Cc: davem@...emloft.net, Emil Tantilov <emil.s.tantilov@...el.com>, netdev@...r.kernel.org, gosp@...hat.com, bphilips@...ell.com Subject: Re: [net-next 08/12] ixgb: convert to new VLAN model On Thu, Jan 6, 2011 at 7:29 PM, <jeffrey.t.kirsher@...el.com> wrote: > +static int ixgb_set_flags(struct net_device *netdev, u32 data) > +{ > + struct ixgb_adapter *adapter = netdev_priv(netdev); > + bool need_reset; > + int rc; > + > + /* > + * TX vlan insertion does not work per HW design when Rx stripping is > + * disabled. Disable txvlan when rxvlan is off. > + */ > + if ((data & ETH_FLAG_RXVLAN) != (netdev->features & NETIF_F_HW_VLAN_RX)) > + data ^= ETH_FLAG_TXVLAN; Does this really do the right thing? If the RX vlan setting is changed, it will do the opposite of what the user requested for TX vlan? So if I start with both on (the default) and turn them both off in one command (a valid setting), I will get RX off and TX on (an invalid setting). Why not: if (!(data & ETH_FLAG_RXVLAN)) data &= ~ETH_FLAG_TXVLAN; -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists