[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4D3A83C2.4000609@grandegger.com>
Date: Sat, 22 Jan 2011 08:14:10 +0100
From: Wolfgang Grandegger <wg@...ndegger.com>
To: David Miller <davem@...emloft.net>
CC: mkl@...gutronix.de, Socketcan-core@...ts.berlios.de,
netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/3] can: at91_can: clean up usage of AT91_MB_RX_FIRST
and AT91_MB_RX_NUM
On 01/22/2011 01:54 AM, David Miller wrote:
> From: Marc Kleine-Budde <mkl@...gutronix.de>
> Date: Mon, 17 Jan 2011 20:50:36 +0100
>
>> On 01/11/2011 02:21 PM, Marc Kleine-Budde wrote:
>>> This patch cleans up the usage of two macros which specify the mailbox
>>> usage. AT91_MB_RX_FIRST and AT91_MB_RX_NUM define the first and the
>>> number of RX mailboxes. The current driver uses these variables in an
>>> unclean way; assuming that AT91_MB_RX_FIRST is 0;
>>>
>>> This patch cleans up the usage of these macros, no longer assuming
>>> AT91_MB_RX_FIRST == 0.
>>>
>>> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
>>
>> Any comments on this?
>
> I would also seriously like to see these changes get some feedback,
> they've been rotting in patchwork for more than a week.
V2 was OK and it got my "Acked-by" here:
http://marc.info/?l=linux-netdev&m=129534267002747&w=2
Wolfgang.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists