netdev - Re: [PATCH v4] net: add Faraday FTMAC100 10/100 Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110131.203556.193730771.davem@davemloft.net>
Date:	Mon, 31 Jan 2011 20:35:56 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ratbert.chuang@...il.com
Cc:	mirqus@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, bhutchings@...arflare.com,
	eric.dumazet@...il.com, joe@...ches.com, dilinger@...ued.net,
	ratbert@...aday-tech.com
Subject: Re: [PATCH v4] net: add Faraday FTMAC100 10/100 Ethernet driver

From: Po-Yu Chuang <ratbert.chuang@...il.com>
Date: Tue, 1 Feb 2011 11:56:16 +0800

> If I simply allocate a page for each rx ring entry, I still need to allocate
> an skb and copy at least packet header in first page to skb->data. Then
> add the page of rest of payload to skb by skb_fill_page_desc().

You should attach the pages, the use __pskb_pull_tail() to bring in the
headers to the linear skb->data area.

See drivers/net/niu.c:niu_process_rx_pkt().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html