netdev - Re: [net-2.6 PATCH 1/3] net: dcb: match dcb_app protocol field with 802.1Qaz spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110131.204104.226756946.davem@davemloft.net>
Date:	Mon, 31 Jan 2011 20:41:04 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	john.r.fastabend@...el.com
Cc:	netdev@...r.kernel.org
Subject: Re: [net-2.6 PATCH 1/3] net: dcb: match dcb_app protocol field
 with 802.1Qaz spec

From: John Fastabend <john.r.fastabend@...el.com>
Date: Mon, 31 Jan 2011 14:00:49 -0800

> The dcb_app protocol field is a __u32 however the 802.1Qaz
> specification defines it as a 16 bit field. This patch brings
> the structure inline with the spec making it a __u16.
> 
> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
 ...
> @@ -101,7 +101,7 @@ struct ieee_pfc {
>   */
>  struct dcb_app {
>  	__u8	selector;
> -	__u32	protocol;
> +	__u16	protocol;
>  	__u8	priority;
>  };
>  

If we're going to do this, please fix this wasteful structure
layout.  Put the "protocol" either first, or last, so that the
structure size is 4 bytes, rather than something like 8.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html