netdev - Re: [PATCH v4 1/5] net: Introduce new feature setting ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110207.125546.104068723.davem@davemloft.net>
Date:	Mon, 07 Feb 2011 12:55:46 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	mirq-linux@...e.qmqm.pl, netdev@...r.kernel.org
Subject: Re: [PATCH v4 1/5] net: Introduce new feature setting ops

From: David Miller <davem@...emloft.net>
Date: Mon, 07 Feb 2011 12:51:20 -0800 (PST)

> From: Ben Hutchings <bhutchings@...arflare.com>
> Date: Mon, 07 Feb 2011 19:39:57 +0000
> 
>> On Thu, 2011-02-03 at 15:21 +0100, Micha┅ Miros┅aw wrote:
>>> This introduces a new framework to handle device features setting.
>>> It consists of:
>>>   - new fields in struct net_device:
>>> 	+ hw_features - features that hw/driver supports toggling
>>> 	+ wanted_features - features that user wants enabled, when possible
>>>   - new netdev_ops:
>>> 	+ feat = ndo_fix_features(dev, feat) - API checking constraints for
>>> 		enabling features or their combinations
>>> 	+ ndo_set_features(dev) - API updating hardware state to match
>>> 		changed dev->features
>>>   - new ethtool commands:
>>> 	+ ETHTOOL_GFEATURES/ETHTOOL_SFEATURES: get/set dev->wanted_features
>>> 		and trigger device reconfiguration if resulting dev->features
>>> 		changed
>>> 	+ ETHTOOL_GSTRINGS(ETH_SS_FEATURES): get feature bits names (meaning)
>>> 
>>> Signed-off-by: Micha┅ Miros┅aw <mirq-linux@...e.qmqm.pl>
>> Reviewed-by: Ben Hutchings <bhutchings@...arflare.com>
> 
> Applied, thanks.

I had to make a fix to this patch, there were duplicate EXPORT_SYMBOL()
lines in net/core/ethtool.c for ethtool_op_set_tx_csum() after your
changes.

How did this build successfully for you?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html