netdev - Re: [PATCH v4 2/5] net: ethtool: use ndo_fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110207.130124.189688858.davem@davemloft.net>
Date:	Mon, 07 Feb 2011 13:01:24 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	mirq-linux@...e.qmqm.pl
Cc:	netdev@...r.kernel.org, bhutchings@...arflare.com
Subject: Re: [PATCH v4 2/5] net: ethtool: use ndo_fix_features for offload
 setting

From: Micha┅ Miros┅aw <mirq-linux@...e.qmqm.pl>
Date: Thu,  3 Feb 2011 15:21:21 +0100 (CET)

> Signed-off-by: Micha┅ Miros┅aw <mirq-linux@...e.qmqm.pl>
> Reviewed-by: Ben Hutchings <bhutchings@...arflare.com>                                                    

Applied, and now I see why the tree "built" successfully for
you.

You remove the duplicate EXPORT_SYMBOL() in this patch.

You absolutely cannot test your patch sets like this, only
build testing at the end.

Every single individual change must not introduce any functional
or build regressions, therefore you must make sure the build works
fine after each and every patch in your series, not just after they
are all applied.

What disturbs me even more, is that really this problem was introduced
because you mixed functional and cleanup changes in the first patch.
Something you should also never do.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html