netdev - Re: [patch] IPVS: precedence bug in ip_vs_sync_switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <div5b80.5723d88b3447e2cae7eaaffaea275f79@obelix.schillstrom.com>
Date:	Mon, 7 Feb 2011 10:34:46 +0100 (CET)
From:	"Hans Schillstrom" <hans@...illstrom.com>
To:	"Dan Carpenter" <error27@...il.com>
Cc:	"Wensong Zhang" <wensong@...ux-vs.org>,
	"Simon Horman" <horms@...ge.net.au>,
	"Julian Anastasov" <ja@....bg>, hans.schillstrom@...csson.com,
	"Patrick McHardy" <kaber@...sh.net>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	lvs-devel@...r.kernel.org, netfilter-devel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] IPVS: precedence bug in ip_vs_sync_switch_mode()

>---- Original Message ----
>From: Dan Carpenter <error27@...il.com>
>To: "Wensong Zhang" <wensong@...ux-vs.org>
>Cc: "Simon Horman" <horms@...ge.net.au>, "Julian Anastasov" <ja@....bg>, hans.schillstrom@...csson.com, "Patrick McHardy" <kaber@...sh.net>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, lvs-devel@...r.kernel.org, netfilter-devel@...r.kernel.org, kernel-janitors@...r.kernel.org
>Sent: Mon, Feb 7, 2011, 9:39 AM
>Subject: [patch] IPVS: precedence bug in ip_vs_sync_switch_mode()
>
>'!' has higher precedence than '&'.  IP_VS_STATE_MASTER is 0x1 so
>the original code is equivelent to if (!ipvs->sync_state) ...
>
Oops,
Thanks
Hans

>Signed-off-by: Dan Carpenter <error27@...il.com>
Signed-off-by: Hans Schillstrom <hans.schillstrom@...csson.com>

>
>diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
>index 2a2a836..d1b7298 100644
>--- a/net/netfilter/ipvs/ip_vs_sync.c
>+++ b/net/netfilter/ipvs/ip_vs_sync.c
>@@ -392,7 +392,7 @@ void ip_vs_sync_switch_mode(struct net *net, int mode)
> {
> 	struct netns_ipvs *ipvs = net_ipvs(net);
> 
>-	if (!ipvs->sync_state & IP_VS_STATE_MASTER)
>+	if (!(ipvs->sync_state & IP_VS_STATE_MASTER))
> 		return;
> 	if (mode == ipvs->sysctl_sync_ver || !ipvs->sync_buff)
> 		return;
>--


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html