netdev - Re: [PATCH net-next-2.6 v7 1/1] can: c_can: Added support for Bosch C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D56982A.5010302@grandegger.com>
Date:	Sat, 12 Feb 2011 15:24:42 +0100
From:	Wolfgang Grandegger <wg@...ndegger.com>
To:	Bhupesh Sharma <bhupesh.sharma@...com>
CC:	netdev@...r.kernel.org, Socketcan-core@...ts.berlios.de
Subject: Re: [PATCH net-next-2.6 v7 1/1] can: c_can: Added support for Bosch
 C_CAN	controller

On 02/11/2011 11:17 AM, Bhupesh Sharma wrote:
> Bosch C_CAN controller is a full-CAN implementation which is compliant
> to CAN protocol version 2.0 part A and B. Bosch C_CAN user manual can be
> obtained from:
> http://www.semiconductors.bosch.de/media/en/pdf/ipmodules_1/
> c_can/users_manual_c_can.pdf
> 
> This patch adds the support for this controller.
> The following are the design choices made while writing the controller
> driver:
> 1. Interface Register set IF1 has be used only in the current design.
> 2. Out of the 32 Message objects available, 16 are kept aside for RX
>    purposes and the rest for TX purposes.
> 3. NAPI implementation is such that both the TX and RX paths function
>    in polling mode.
> 
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@...com>
> ---
> Changes since V6:
> 1. Added check for calling netif_stop_queue() in case next TX object
>    is busy.
> 2. Added logic *not* to copy data to rx'ed RTR frames.
> 3. Moved enums, defines and structs present in c_can.h file to the respective
>    c-file where they are actually used.
> 4. Corrected message object busy status routine by using a better name
>    and design approach.
> 5. Moved *set_bittiming* call to the *c_can_chip_config* function.

Acked-by: Wolfgang Grandegger <wg@...ndegger.com>

Thanks for your contribution. As soon as the patch is accepted, I will
send a patch for the PCH CAN.

Wolfgang.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html