netdev - Re: [PATCH 1/2] bonding: fix incorrect transmit queue offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110223234336.GH11864@gospo.rdu.redhat.com>
Date:	Wed, 23 Feb 2011 18:43:36 -0500
From:	Andy Gospodarek <andy@...yhouse.net>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	David Miller <davem@...emloft.net>, kernel@...uxace.com,
	andy@...yhouse.net, netdev@...r.kernel.org, fubar@...ibm.com
Subject: Re: [PATCH 1/2] bonding: fix incorrect transmit queue offset

On Wed, Feb 23, 2011 at 11:37:49PM +0000, Ben Hutchings wrote:
> On Wed, 2011-02-23 at 15:13 -0800, David Miller wrote:
> > From: Phil Oester <kernel@...uxace.com>
> > Date: Wed, 23 Feb 2011 15:08:44 -0800
> > 
> > > On Wed, Feb 23, 2011 at 02:42:49PM -0500, Andy Gospodarek wrote:
> > >> + * destination queue.  Using a helper function skips the a call to
> > > 
> > > s/the a/a/ or s/the a/the/
> > > 
> > >> +     while (txq >= dev->real_num_tx_queues) {
> > >> +             /* let the user know if we do not have enough tx queues */
> > >> +             if (net_ratelimit())
> > >> +                     pr_warning("%s selects invalid tx queue %d.  Consider"
> > >> +                                " setting module option tx_queues > %d.",
> > >> +                                dev->name, txq, dev->real_num_tx_queues);
> > >> +             txq -= dev->real_num_tx_queues;
> > >> +     }
> > > 
> > > Think this would be better as a WARN_ONCE, as otherwise syslog will still
> > > get flooded with this - even when ratelimited.  See get_rps_cpu in 
> > > net/core/dev.c as an example.o
> > 
> > Agreed.
> 
> This shouldn't WARN at all.  It is perfectly valid (though non-optimal)
> to have different numbers of queues on two different multiqueue devices.
> 

Agreed.  Plus WARN seemed way to 'loud' for something like this.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html