netdev - Re: [PATCH] via-rhine: do not abort due to invalid MAC address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110302.113610.71137356.davem@davemloft.net>
Date:	Wed, 02 Mar 2011 11:36:10 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	mr.nuke.me@...il.com
Cc:	florian@...nwrt.org, rl@...lgate.ch, netdev@...r.kernel.org
Subject: Re: [PATCH] via-rhine: do not abort due to invalid MAC address

From: "Alex G." <mr.nuke.me@...il.com>
Date: Wed, 02 Mar 2011 20:11:08 +0200

> On 03/02/2011 08:01 PM, Florian Fainelli wrote:
>> 
>> Why not generate a valid random ethernet address using random_ether_addr() 
>> instead?
> 
> That would confuse ifcfg-* scripts that specify HWETHER, and probably
> users as well. It might even stump udev.

If the ethernet address reported by the card is garbage, every single
ethernet driver that tried to handle this case uses a random ethernet
address.

There is no reason to choose a different strategy for this driver.

Also registering a network device with an invalid ethernet address can
cause all kinds of serious issues, let's say dhcp brings the device
up and emits DHCP requests with illegal MAC addresses in the header
because of this problem.

You therefore simply cannot leave crap in there.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html