netdev - Re: [PATCH] via-rhine: do not abort due to invalid MAC address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110302195205.GA15190@core.hellgate.ch>
Date:	Wed, 2 Mar 2011 20:52:05 +0100
From:	Roger Luethi <rl@...lgate.ch>
To:	David Miller <davem@...emloft.net>
Cc:	mr.nuke.me@...il.com, florian@...nwrt.org, netdev@...r.kernel.org
Subject: Re: [PATCH] via-rhine: do not abort due to invalid MAC address

On Wed, 02 Mar 2011 11:36:10 -0800, David Miller wrote:
> From: "Alex G." <mr.nuke.me@...il.com>
> Date: Wed, 02 Mar 2011 20:11:08 +0200
> 
> > On 03/02/2011 08:01 PM, Florian Fainelli wrote:
> >> 
> >> Why not generate a valid random ethernet address using random_ether_addr() 
> >> instead?
> > 
> > That would confuse ifcfg-* scripts that specify HWETHER, and probably
> > users as well. It might even stump udev.
> 
> If the ethernet address reported by the card is garbage, every single
> ethernet driver that tried to handle this case uses a random ethernet
> address.
>
> There is no reason to choose a different strategy for this driver.

Fair enough. I did not know other drivers had already dealt with the same
problem. My bad. Alex, can you redo the patch accordingly?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html