[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20110307.132721.246531926.davem@davemloft.net>
Date:	Mon, 07 Mar 2011 13:27:21 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	roland@...estorage.com
Cc:	yevgenyp@...lanox.co.il, netdev@...r.kernel.org, eli@...lanox.co.il
Subject: Re: [PATCH 13/17] mlx4: Add blue flame support for kernel consumers
From: Roland Dreier <roland@...estorage.com>
Date: Mon, 7 Mar 2011 13:07:48 -0800
> On Mon, Mar 7, 2011 at 2:17 AM, Yevgeny Petrilin
> <yevgenyp@...lanox.co.il> wrote:
>> +       if (map_bf_area(dev))
>> +               mlx4_dbg(dev, "Kernel support for blue flame is not available for kernels < 2.6.28\n");
> 
> This seems like a really bad error message.  Can map_bf_area() actually fail?
Indeed, referencing specific old kernel versions in the upstream
driver makes no sense at all.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists
 
