netdev - Re: [net-next-2.6 04/14] net: add ndo_fcoe_ddp_target() to support FCoE DDP in target mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1299552202.3967.2.camel@localhost>
Date:	Tue, 08 Mar 2011 02:43:22 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, Yi Zou <yi.zou@...el.com>,
	netdev@...r.kernel.org, gospo@...hat.com, bphilips@...ell.com,
	Kiran Patil <kiran.patil@...el.com>
Subject: Re: [net-next-2.6 04/14] net: add ndo_fcoe_ddp_target() to support
 FCoE DDP in target mode

On Mon, 2011-03-07 at 18:24 -0800, Jeff Kirsher wrote:
> From: Yi Zou <yi.zou@...el.com>
> 
> The Fiber Channel over Ethernet (FCoE) Direct Data Placement (DDP) can also be
> used for FCoE target, where the DDP used for read I/O on an initiator can be
> used on an FCoE target to speed up the write I/O to the target from the initiator.
> The added ndo_fcoe_ddp_target() works in the similar way as the existing
> ndo_fcoe_ddp_setup() to allow the underlying hardware set up the DDP context
> accordingly when it gets called from the FCoE target implementation on top
> the existing Open-FCoE fcoe/libfc protocol stack so without losing the ability
> to provide DDP for read I/O as an initiator, it can also provide DDP offload
> to the write I/O coming from the initiator as a target.
> 
> Signed-off-by: Yi Zou <yi.zou@...el.com>
> Signed-off-by: Kiran Patil <kiran.patil@...el.com>
> Tested-by: Kavindya Deegala <kavindya.s.deegala@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>  include/linux/netdevice.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 71563e7..6bd5d46 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -871,6 +871,10 @@ struct net_device_ops {
>  						      unsigned int sgc);
>  	int			(*ndo_fcoe_ddp_done)(struct net_device *dev,
>  						     u16 xid);
> +	int			(*ndo_fcoe_ddp_target)(struct net_device *dev,
> +						       u16 xid,
> +						       struct scatterlist *sgl,
> +						       unsigned int sgc);

This should be described in the comment heading net_device_ops.
(Really, all the existing FCoE operations ought to have been described
as well.)

Ben.

>  #define NETDEV_FCOE_WWNN 0
>  #define NETDEV_FCOE_WWPN 1
>  	int			(*ndo_fcoe_get_wwn)(struct net_device *dev,

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html