netdev - Re: [PATCH 1/2] macvlan : fix checksums error when we are in bridge mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1300122277.3423.132.camel@edumazet-laptop>
Date:	Mon, 14 Mar 2011 18:04:37 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Daniel Lezcano <daniel.lezcano@...e.fr>
Cc:	davem@...emloft.net, kaber@...sh.net, nightnord@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] macvlan : fix checksums error when we are in
 bridge mode

Le lundi 14 mars 2011 à 17:08 +0100, Daniel Lezcano a écrit :
> When the lower device has offloading capabilities, the packets checksums
> are not computed. That leads to have any macvlan port in bridge mode to
> not work because the packets are dropped due to a bad checksum.
> 
> If the macvlan is in bridge mode, the packet is forwarded to another
> macvlan port and reach the network stack where it looks for a checksum
> but this one was not computed due to the offloading of the lower device.
> In this case, we have to set the packet with CHECKSUM_UNNECESSARY
> when it is forwarded to a bridged port and restore the previous value of
> ip_summed when the packet goes to the lowerdev.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...e.fr>
> Cc: Patrick McHardy <kaber@...sh.net>
> Cc: Andrian Nord <nightnord@...il.com>

Acked-by: Eric Dumazet <eric.dumazet@...il.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html