netdev - Re: [PATCH] Fix possible null pointer dereference in ehea

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110314.153456.52185310.davem@davemloft.net>
Date:	Mon, 14 Mar 2011 15:34:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	huzaifas@...hat.com
Cc:	netdev@...r.kernel.org, leitao@...ux.vnet.ibm.com
Subject: Re: [PATCH] Fix possible null pointer dereference in ehea_qmr.c

From: huzaifas@...hat.com
Date: Mon, 14 Mar 2011 13:16:04 +0530

> From: Huzaifa Sidhpurwala <huzaifas@...hat.com>
> 
> If queue is zero, dont reference it
> 
> Signed-off-by: Huzaifa Sidhpurwala <huzaifas@...hat.com>

There is no code path where hw_queue_dtor() is called with a NULL
"queue".  I've checked all of the code paths.

Therefore it's better to simply remove the NULL check.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html