netdev - Re: [PATCH] Fix possible null pointer dereference in davinci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110314.153616.13749823.davem@davemloft.net>
Date:	Mon, 14 Mar 2011 15:36:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	huzaifas@...hat.com
Cc:	netdev@...r.kernel.org, khilman@...prootsystems.com, cyril@...com
Subject: Re: [PATCH] Fix possible null pointer dereference in
 davinci_cpdma.c

From: huzaifas@...hat.com
Date: Mon, 14 Mar 2011 14:09:14 +0530

> From: Huzaifa Sidhpurwala <huzaifas@...hat.com>
> 
> Check if chan exists before dereferencing it
> 
> Signed-off-by: Huzaifa Sidhpurwala <huzaifas@...hat.com>

Just like your EHEA driver patch, this situation is such that
cpdma_chan_destroy() is never called with a NULL "chan" argument.

Therefore it's better to simply remove the NULL check.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html