netdev - Re: [patch net-next-2.6 1/6] af_packet: use skb->skb_iif instead of orig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110314074342.GB2751@psychotron.redhat.com>
Date:	Mon, 14 Mar 2011 08:43:43 +0100
From:	Jiri Pirko <jpirko@...hat.com>
To:	Changli Gao <xiaosuo@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	shemminger@...ux-foundation.org, kaber@...sh.net, fubar@...ibm.com,
	eric.dumazet@...il.com, nicolas.2p.debian@...il.com,
	andy@...yhouse.net
Subject: Re: [patch net-next-2.6 1/6] af_packet: use skb->skb_iif instead of
 orig_dev->ifindex

Mon, Mar 14, 2011 at 07:59:39AM CET, xiaosuo@...il.com wrote:
>On Mon, Mar 14, 2011 at 2:54 PM, Jiri Pirko <jpirko@...hat.com> wrote:
>> Mon, Mar 14, 2011 at 12:52:37AM CET, xiaosuo@...il.com wrote:
>>>On Sat, Mar 12, 2011 at 9:14 PM, Jiri Pirko <jpirko@...hat.com> wrote:
>>>> Since skb_iif has the desired value (ifindex of physical device actually
>>>> received the traffic) use that instead.
>>>>
>>>> Signed-off-by: Jiri Pirko <jpirko@...hat.com>
>>>> Reviewed-by: Changli Gao <xiaosuo@...il.com>
>>>> Reviewed-by: Nicolas de Pesloüan <nicolas.2p.debian@...e.fr>
>>>> ---
>>>
>>>This may "break" the ptype handlers in TX path, as we always assign
>>>skb->dev to origdev there. Thanks.
>>
>> Changli, would you please point me the relevant code?. Thanks!
>>
>
>1557 static void dev_queue_xmit_nit(struct sk_buff *skb, struct net_device *dev)
>....
>
>1571                         if (pt_prev) {
>1572                                 deliver_skb(skb2, pt_prev, skb->dev);
>1573                                 pt_prev = ptype;
>1574                                 continue;
>1575                         }
>...
>1603         }
>1604         if (pt_prev)
>1605                 pt_prev->func(skb2, skb->dev, pt_prev, skb->dev);
>1606         rcu_read_unlock();
>1607 }

I'm probably missign something but I do not see the connection between
this and setting up sll->sll_ifindex in net/packet/af_packet.c

>
>-- 
>Regards,
>Changli Gao(xiaosuo@...il.com)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html