netdev - Re: [PATCH] Disable rp_filter for IPsec packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1103151913340.28997@juice.ott.cti.com>
Date:	Tue, 15 Mar 2011 19:21:29 -0400 (EDT)
From:	Michael Smith <msmith@...co.com>
To:	David Miller <davem@...emloft.net>
cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] Disable rp_filter for IPsec packets

On Mon, 14 Mar 2011, David Miller wrote:

> > David Miller wrote:
> > 
> >> Existing arguments might be large enough to carry more than one piece
> >> of information :-)
> > 
> > If it's encoded into another argument, would there be more overhead
> > from bit-shifting it out than you'd save by losing an argument?
> 
> It sure will if it's the different between the argument being passed
> in a register vs. on the stack.

I have a patch to replace u32 mark with an sk_buff. The mark is in the 
sk_buff already, and so is the secpath field I need. Would that be 
acceptable? I can hold off until the merge window is over.

-extern int fib_validate_source(__be32 src, __be32 dst, u8 tos, int oif,
-                              struct net_device *dev, __be32 *spec_dst,
-                              u32 *itag, u32 mark);

+extern int fib_validate_source(struct sk_buff *skb, __be32 src, __be32 dst,
+                              u8 tos, int oif, struct net_device *dev,
+                              __be32 *spec_dst, u32 *itag);

(dev is also usually the same as skb->dev, but not always...)

Mike
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html