netdev - Re: [PATCHv2 0/9] macb: add support for Cadence GEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110316.131734.242138246.davem@davemloft.net>
Date:	Wed, 16 Mar 2011 13:17:34 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jamie@...ieiles.com
Cc:	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	nicolas.ferre@...el.com, plagnioj@...osoft.com
Subject: Re: [PATCHv2 0/9] macb: add support for Cadence GEM

From: Jamie Iles <jamie@...ieiles.com>
Date: Tue, 15 Mar 2011 10:14:47 +0000

> This patch series extends the Atmel MACB driver to support the Cadence
> GEM (Gigabit Ethernet MAC) to support 10/100 operation.  The GEM is
> based on the MACB block but has a few moved registers and bitfields.
> This patch series attempts to use the MACB accessors where block
> functionallity is identical and only overrides to GEM specific
> acccessors when needed.
> 
> This has been runtested on a board with a Cadence GEM and compile tested
> for all at91 configurations and a number of avr32 configurations.
> 
> Changes since v1:
> 	- AT91 now provides a fake "hclk" and "macb_clk" has been
> 	renamed to "pclk" to be consistent with AVR32.
> 	- Configurable GEM receive buffer size support has been added.
> 	- pr_foo() and dev_foo() have been converted to netdev_foo()
> 	where appropriate.
> 	- New conditional accessors (macb_or_gem_{read,write}l) have
> 	been introduced that do the conditional accesses dependent on
> 	macb/gem type.
> 	- GEM is now dynamically detected from the module ID rather than
> 	platform device name.
> 
> Jean-Christophe, I haven't based this on your conditional clock patch as
> I wasn't sure what decision had been made on that and whether the
> at91/avr32 detection is reliable.

I'm happy to ACK this so you guys can merge this via one of the
ARM trees:

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html