netdev - Re: [PATCHv2 1/9] at91: provide macb clks with "pclk" and "hclk" name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110316083844.GA13262@n2100.arm.linux.org.uk>
Date:	Wed, 16 Mar 2011 08:38:44 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	"avictor.za@...il.com" <avictor.za@...il.com>
Cc:	Jamie Iles <jamie@...ieiles.com>, netdev@...r.kernel.org,
	plagnioj@...osoft.com, linux-arm-kernel@...ts.infradead.org,
	nicolas.ferre@...el.com
Subject: Re: [PATCHv2 1/9] at91: provide macb clks with "pclk" and "hclk"
	name

On Wed, Mar 16, 2011 at 08:53:47AM +0200, avictor.za@...il.com wrote:
> hi,
> 
> On Tue, Mar 15, 2011 at 12:14 PM, Jamie Iles <jamie@...ieiles.com> wrote:
> > The macb driver expects clocks with the names "pclk" and "hclk".  We
> > currently provide "macb_clk" but to fit in line with other
> > architectures (namely AVR32), provide "pclk" and a fake "hclk".
> 
> There is no reference to a "pclk" or "hclk" in the AT91 architecture.
> So to avoid possible confusion, maybe create two "fake" clocks both
> parented to "macb_clk", and add a comment they're only for
> compatibility with the AVR32.

It doesn't matter what's in the documentation.

There's no apb_pclk mentioned in the ARM platform documentation yet we
have such a clock in the bus-level code for primecell support.  I'm sure
many of the other early primecell using platforms are also the same.

On OMAP1 there's no iclk yet OMAP drivers have had iclk and iclk is a
dummy no-op clock for OMAP1 for compatibility with OMAP2.

What matters more than conforming to documentation is keeping the drivers
in a clean and maintainable state without throwing lots of ifdefs into
them.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html