netdev - Re: [PATCH net-dev2.6] bxn2x: Fix location of PCI-ids defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1300367613.31873.0.camel@lb-tlvb-eilong.il.broadcom.com>
Date:	Thu, 17 Mar 2011 15:13:33 +0200
From:	"Eilon Greenstein" <eilong@...adcom.com>
To:	"David Miller" <davem@...emloft.net>
cc:	"Ariel Elior" <ariele@...adcom.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-dev2.6] bxn2x: Fix location of PCI-ids defines

On Thu, 2011-03-17 at 06:06 -0700, David Miller wrote:
> From: "Ariel Elior" <ariele@...adcom.com>
> Date: Thu, 17 Mar 2011 14:27:04 +0200
> 
> > Signed-off-by: Ariel Elior <ariele@...adcom.com>
> > Signed-off-by: Eilon Greenstein <eilong@...adcom.com>
> 
> Unless you intend to reference these symbols elsewhere in the
> kernel, they should stay private in your driver.
> 

The bnx2i will need it as well. Isn't it better to keep all the PCI IDs
in the same global location?

Thanks,
Eilon


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html