netdev - Re: [PATCH] netfilter: xtables: fix reentrancy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1300367841.6315.9.camel@edumazet-laptop>
Date:	Thu, 17 Mar 2011 14:17:21 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jesper Dangaard Brouer <hawk@...u.dk>
Cc:	David Miller <davem@...emloft.net>,
	Patrick McHardy <kaber@...sh.net>,
	Netfilter Developers <netfilter-devel@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] netfilter: xtables: fix reentrancy

Le jeudi 17 mars 2011 à 12:45 +0100, Eric Dumazet a écrit :
> Le jeudi 17 mars 2011 à 12:36 +0100, Jesper Dangaard Brouer a écrit :
> > Hi Eric,
> > 
> > How critial is this bug fix?
> > 
> > Should I apply this on my stable production kernels?
> > (I'm preparing a 2.6.38 kernel for prod usage, eventhougt its just been 
> > released, because I want your SFQ fixes...)
> 
> I would say the race is there, but probability must be very small, and
> might need malicious iptables rules (with RETURN targets)
> 
> Especially in routers, where OUTPUT path is taken from softirq handler
> anyway ;)
> 
> So dont worry at all, consider this as a cleanup :)
> 

Almost forgot to mention your kernels probably have :

CONFIG_PREEMPT_NONE=y
# CONFIG_PREEMPT is not set

So you can take it easy ;)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html