netdev - Re: xfrm: Fix initialize repl field of struct xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110320.234606.183056322.davem@davemloft.net>
Date:	Sun, 20 Mar 2011 23:46:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	yjwei@...fujitsu.com
Cc:	netdev@...r.kernel.org, steffen.klassert@...unet.com
Subject: Re: xfrm: Fix initialize repl field of struct xfrm_state

From: Wei Yongjun <yjwei@...fujitsu.com>
Date: Mon, 21 Mar 2011 14:36:45 +0800

> Sorry for not said clearly, at the first time I want to do like this. 
> But when I grep 'xfrm_init_state', it be used in many place, not
> any pf_key, but also XFRM MIGRATE, ipcomp, ipcomp6. So I did this ugly
> patch by add this to xfrm_init_state() to avoid dup code.
> 
> Not sure whether the other case like ipcomp/ipcomp6 etc can cause panic, if
> it panic, maybe we can fix by introduce new xfrm_init_replay() function
> like to assign the default reply function.
>   int xfrm_init_replay(struct xfrm_state *x)
>   {
>   	x->repl = &xfrm_replay_legacy;
>   	return 0;
>   }
> and change the orig xfrm_init_replay to xfrm_update_replay()? 
> Or dup those code to all used place?
> 
> If I was wrong, I will fix this by adding the necessary call to af_key.c.

Ok, thanks for the explanation.

I think there is a simple way out of this:

1) Rename current xfrm_init_state to __xfrm_init_state, add
   "bool init_replay" argument.  Add the xfrm_init_replay()
   call, as in your patch, but conditionalized on this boolean.

2) Implement xfrm_init_state as inline, which calls
   __xfrm_init_state(..., true)

3) Replace xfrm_init_state() call in xfrm_user.c with
   __xfrm_init_state(..., false)

This seems to avoid all the problems.  We don't need to touch every
caller, and we avoid initializing the replay state twice in xfrm_user

Ok?


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html