netdev - Re: [RFC][PATCH]: e1000e: If ASPM L0s needs to be disabled, do it prior to enabling device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTik0XBfbYuSa1v0v4vAdGAYXsn1c7qPpUJU593C8@mail.gmail.com>
Date:	Tue, 22 Mar 2011 21:08:26 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Naga Chumbalkar <nagananda.chumbalkar@...com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	bruce.w.allan@...el.com
Subject: Re: [RFC][PATCH]: e1000e: If ASPM L0s needs to be disabled, do it
 prior to enabling device

On Tue, Mar 22, 2011 at 12:48, Naga Chumbalkar
<nagananda.chumbalkar@...com> wrote:
> If ASPM L0s needs to be disabled due to HW errata, do it prior to
> "enabling" the device. This way if the kernel ever defaults its
> aspm_policy to POLICY_POWERSAVE, then the e1000e driver will get a
> chance to disable ASPM on the misbehaving device *prior* to calling
> pci_enable_device_mem(). This will be useful in situations
> where the BIOS indicates ASPM support on the server by clearing the
> ACPI FADT "ASPM Controls" bit.
>
> Note:
> The kernel (2.6.38) currently uses the BIOS "default" as its aspm_policy.
> However, Linux distros can diverge from that and set the default to "powersave".
>
> Signed-off-by: Naga Chumbalkar <nagananda.chumbalkar@...com>
> Cc: Bruce Allan <bruce.w.allan@...el.com>
>
> ---
>  drivers/net/e1000e/82571.c  |   10 +++++-----
>  drivers/net/e1000e/e1000.h  |    1 +
>  drivers/net/e1000e/netdev.c |   25 +++++++++++++++++++++----
>  3 files changed, 27 insertions(+), 9 deletions(-)
>

I have added this patch to my queue of e1000e patches.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html