netdev - Re: [PATCH v2 08/16] mlx4_en: Reporting HW revision in ethtool -i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110323.123427.242111674.davem@davemloft.net>
Date:	Wed, 23 Mar 2011 12:34:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	yevgenyp@...lanox.co.il, netdev@...r.kernel.org,
	eugenia@...lanox.co.il
Subject: Re: [PATCH v2 08/16] mlx4_en: Reporting HW revision in ethtool -i

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Wed, 23 Mar 2011 14:04:14 +0000

> On Wed, 2011-03-23 at 10:38 +0200, Yevgeny Petrilin wrote:
>> HW revision is derived from device ID and rev id.
> [...]
>> -	sprintf(drvinfo->driver, DRV_NAME " (%s)", mdev->dev->board_id);
>> +	switch (mdev->dev->rev_id) {
>> +	case 0xa0:
>> +		if (dev->dev_id >= MLX4_EN_CX3_LOW_ID && dev->dev_id <= MLX4_EN_CX3_HIGH_ID)
>> +			sprintf(drvinfo->driver, DRV_NAME " (%s_CX-3)", mdev->dev->board_id);
>> +		else
>> +			sprintf(drvinfo->driver, DRV_NAME " (%s_CX)", mdev->dev->board_id);
>> +		break;
>> +	case 0xb0:
>> +		sprintf(drvinfo->driver, DRV_NAME " (%s_CX-2)", mdev->dev->board_id);
>> +		break;
>> +	default:
>> +		sprintf(drvinfo->driver, DRV_NAME " (%s)", mdev->dev->board_id);
>> +		break;
> [...]
> 
> This is an abuse of the ethtool_drvinfo::driver field.
> 
> Your users can use lspci -v, can't they?

Agreed, mlx4 folks please send me a follow-up patch that removes this
conditional string.

The driver string is only meant to identify the software, not the
hardware variant.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html