netdev - Re: [PATCH v2 08/16] mlx4_en: Reporting HW revision in ethtool -i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110323.123643.200348134.davem@davemloft.net>
Date:	Wed, 23 Mar 2011 12:36:43 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	yevgenyp@...lanox.co.il
Cc:	bhutchings@...arflare.com, netdev@...r.kernel.org,
	eugenia@...lanox.co.il
Subject: Re: [PATCH v2 08/16] mlx4_en: Reporting HW revision in ethtool -i

From: Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Date: Wed, 23 Mar 2011 15:10:34 +0000

>> 
>> This is an abuse of the ethtool_drvinfo::driver field.
>> 
>> Your users can use lspci -v, can't they?
>> 
> I don't think there is a problem here.
> We have always reported the HW model via Ethtool, we just expanded the information
> we provide.
> Our users prefer to see the information in ethtool.

This doesn't matter, we strive for consistency across drivers rather
than have special cases like this.

Please remove the chip variant information from the ethtool driver
string, it is absolutely not appropriate.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html