netdev - Re: [RFC] usbnet: use eth%d name for known ethernet devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201103232035.18232.arnd@arndb.de>
Date:	Wed, 23 Mar 2011 20:35:17 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Greg KH <greg@...ah.com>
Cc:	andy.green@...aro.org, Alan Cox <alan@...rguk.ukuu.org.uk>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Jaswinder Singh <jaswinder.singh@...aro.org>,
	Linux USB list <linux-usb@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	broonie@...nsource.wolfsonmicro.com, roger.quadros@...ia.com,
	grant.likely@...retlab.ca, netdev@...r.kernel.org,
	David Brownell <dbrownell@...rs.sourceforge.net>
Subject: Re: [RFC] usbnet: use eth%d name for known ethernet devices

On Wednesday 23 March 2011 19:46:50 Greg KH wrote:
> Looks good to me, but some questions:
> 
> >  drivers/usb/serial/usb_wwan.c |    2 +-
> 
> You don't modify this file in the diff, what caused this to show up in
> the diffstat?

A stale change I had to do to get the kernel to build on my
machine. The original problem seems fixed now. I had removed
this hunk from the patch but forgot to remove it from the diffstat.

> > --- a/include/linux/usb/usbnet.h
> > +++ b/include/linux/usb/usbnet.h
> > @@ -97,6 +97,8 @@ struct driver_info {
> >  
> >  #define FLAG_LINK_INTR       0x0800          /* updates link (carrier) status */
> >  
> > +#define FLAG_PTP     0x1000          /* maybe use "usb%d" names */
> 
> "PTP"?  What does that stand for?

point-to-point, I'll improve the comment to spell it out when I send the
fixed version.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html