netdev - RE: [PATCH] net: ethtool support to configure number of channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99737F4847ED0A48AECC9F4A1974A4B80FD10E8D93@MNEXMB2.qlogic.org>
Date:	Fri, 1 Apr 2011 21:36:52 -0500
From:	Amit Salecha <amit.salecha@...gic.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Ameen Rahman <ameen.rahman@...gic.com>,
	Sucheta Chakraborty <sucheta.chakraborty@...gic.com>,
	Anirban Chakraborty <anirban.chakraborty@...gic.com>
Subject: RE: [PATCH] net: ethtool support to configure number of channels

> I'm not sure why you reduced this to a single count.  If if the driver
> or hardware doesn't allow certain combinations of counts, it might be
> necessary to configure several types at the same time
>
> > +/* Channel ID is made up of a type */
> > +enum ethtool_channel_id {
> > +   ETH_CHAN_TYPE_RX = 0x1,
> > +   ETH_CHAN_TYPE_TX = 0x2
> > +};
> [...]
>
> enum ethtool_channel_id was meant to be an identifier of a specific
> channel.  An enumeration of channel types should be named differently.
>

I will name it as ethtool_channel_type. Any other suggestion ?

> This also omits the 'combined' and 'other' types.  Most multiqueue
> drivers pair up RX and TX queues so that most channels combine RX and
> TX
> work.

'combined' is ok, what is use of 'other' ?

-amit

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.