netdev - Re: [patch net-next-2.6] net: vlan: make non-hw-accel rx path similar to hw-accel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110405072621.GC3640@psychotron.lan>
Date:	Tue, 5 Apr 2011 09:26:22 +0200
From:	Jiri Pirko <jpirko@...hat.com>
To:	Nicolas de Pesloüan 
	<nicolas.2p.debian@...il.com>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Jesse Gross <jesse@...nel.org>, netdev@...r.kernel.org,
	davem@...emloft.net, shemminger@...ux-foundation.org,
	kaber@...sh.net, fubar@...ibm.com, eric.dumazet@...il.com,
	andy@...yhouse.net, xiaosuo@...il.com
Subject: Re: [patch net-next-2.6] net: vlan: make non-hw-accel rx path
 similar to hw-accel

Mon, Apr 04, 2011 at 10:47:48PM CEST, nicolas.2p.debian@...il.com wrote:
>Le 04/04/2011 21:51, Eric W. Biederman a écrit :
>
>>
>>__netif_receive_skb is actually late for untagging.  eth_type_trans
>>would be better but not path of control into __netif_receive_skb
>>actually calls eth_type_trans.
>
>Because vlan may nest, we need to keep some sort of frame untagging inside __netif_receive_skb.

You are correct here. It needs to stay inside __netif_receive_skb
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html