netdev - Re: [patch net-next-2.6] net: vlan: make non-hw-accel rx path similar to hw-accel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110405072459.GB3640@psychotron.lan>
Date:	Tue, 5 Apr 2011 09:25:00 +0200
From:	Jiri Pirko <jpirko@...hat.com>
To:	Nicolas de Pesloüan 
	<nicolas.2p.debian@...il.com>
Cc:	Jesse Gross <jesse@...nel.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	netdev@...r.kernel.org, davem@...emloft.net,
	shemminger@...ux-foundation.org, kaber@...sh.net, fubar@...ibm.com,
	eric.dumazet@...il.com, andy@...yhouse.net, xiaosuo@...il.com
Subject: Re: [patch net-next-2.6] net: vlan: make non-hw-accel rx path
 similar to hw-accel

Mon, Apr 04, 2011 at 11:04:09PM CEST, nicolas.2p.debian@...il.com wrote:
>Le 04/04/2011 22:50, Jesse Gross a écrit :
>>On Mon, Apr 4, 2011 at 1:47 PM, Nicolas de Pesloüan
>><nicolas.2p.debian@...il.com>  wrote:
>>>Can someone clarify whether hwaccel capable NIC will always untag tagged
>>>frames or will only do so if requested at device setup?
>>
>>It can be changed on the fly by ethtool, similar to other forms of offloading.
>
>Thanks Jesse.
>
>So if hwaccell vlan untagging is disabled, what is the current
>behavior? Is the frame delivered untouched (tagged) to ptype_all
>handlers if no particular vlan device is setup on the parent device?

Even if vlan device is setup on the parent device.

>
>With Jiri's patch, it would be always untagged, whatever requested by ethtool.

Correct. That's more or less purpose of the patch.

>
>Am I right?
>
>	Nicolas.
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html