[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20110412.154642.200375628.davem@davemloft.net>
Date: Tue, 12 Apr 2011 15:46:42 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: blogic@...nwrt.org
Cc: ralf@...ux-mips.org, ralph.hempel@...tiq.com,
linux-mips@...ux-mips.org, netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] MIPS: lantiq: add ethernet driver
From: John Crispin <blogic@...nwrt.org>
Date: Tue, 12 Apr 2011 18:11:14 +0200
> This patch adds the driver for the ETOP Packet Processing Engine (PPE32) found
> inside the XWAY family of Lantiq MIPS SoCs. This driver makes 100MBit ethernet
> work. Support for all 8 dma channels, gbit and the embedded switch found on
> the ar9/vr9 still needs to be implemented.
>
> Signed-off-by: John Crispin <blogic@...nwrt.org>
> Signed-off-by: Ralph Hempel <ralph.hempel@...tiq.com>
This driver needs some work.
> +
> + skb_put(skb, len);
> + skb->dev = dev;
> + skb->protocol = eth_type_trans(skb, dev);
> + netif_rx(skb);
> + priv->stats.rx_packets++;
> + priv->stats.rx_bytes += len;
Please convert this driver to use NAPI for packet reception.
> + local_irq_save(flags);
> + priv->rx_tasklet_running = 0;
> + if (priv->rx_channel_mask) {
> + priv->rx_tasklet_running = 1;
> + tasklet_schedule(&priv->rx_tasklet);
> + }
> + local_irq_restore(flags);
This doesn't protect anything, use proper locking.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists