netdev - Re: [PATCH 2/3] MIPS: lantiq: add ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110412165424.0b6ba71a@nehalam>
Date:	Tue, 12 Apr 2011 16:54:24 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	John Crispin <blogic@...nwrt.org>
Cc:	Ralf Baechle <ralf@...ux-mips.org>,
	Ralph Hempel <ralph.hempel@...tiq.com>,
	linux-mips@...ux-mips.org, netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] MIPS: lantiq: add ethernet driver

On Tue, 12 Apr 2011 18:11:14 +0200
John Crispin <blogic@...nwrt.org> wrote:

> +
> +struct ltq_mii_priv {
> +	struct ltq_eth_data *pldata;
> +	struct resource *res;
> +	struct net_device_stats stats;

You don't need to have private stats structure it is part
of net_device in recent kernels. In fact, since you don't
set .ndo_get_stats, the driver is getting the default function
which prints the values from network_device, not your priv structure.

Also, please consider adding basic ethtool support to
show speed/duplex and driver information.

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html