[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20110414.215524.104068954.davem@davemloft.net>
Date: Thu, 14 Apr 2011 21:55:24 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: bhutchings@...arflare.com
Cc: shemminger@...tta.com, shodgson@...arflare.com,
linux-net-drivers@...arflare.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] sfc: make function tables const
From: Ben Hutchings <bhutchings@...arflare.com>
Date: Thu, 14 Apr 2011 17:37:18 +0100
> On Thu, 2011-04-14 at 08:50 -0700, Stephen Hemminger wrote:
>> The phy, mac, and board information structures should be const.
>
> efx_nic_type actually holds information and function pointers about
> different generations of the controller, not different boards.
>
>> Since tables contain function pointer this improves security
>> (at least theoretically).
>>
>> Compile tested only.
>>
>> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> Acked-by: Ben Hutchings <bhutchings@...arflare.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists