netdev - Re: [PATCH net-next] sfc: make function tables const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1302799038.2853.5.camel@bwh-desktop>
Date:	Thu, 14 Apr 2011 17:37:18 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	Steve Hodgson <shodgson@...arflare.com>,
	Solarflare linux maintainers <linux-net-drivers@...arflare.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] sfc: make function tables const

On Thu, 2011-04-14 at 08:50 -0700, Stephen Hemminger wrote:
> The phy, mac, and board information structures should be const.

efx_nic_type actually holds information and function pointers about
different generations of the controller, not different boards.

> Since tables contain function pointer this improves security
> (at least theoretically).
> 
> Compile tested only.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
Acked-by: Ben Hutchings <bhutchings@...arflare.com>

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html